Feature/dark theme ehancements - shimmer time! #2762
Conversation
bit of gloss :)
|
dosubot
bot
added
the
size:L
|
The changes in this pull request seem cohesive and related to UI/UX enhancements, specifically focusing on dark theme improvements and styling updates. Therefore, it does not need to be split into smaller pull requests. If you have any questions or need further clarification, feel free to reach out! |
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
|
yeh good point |
|
Generally speaking, visual flair is always nice. But I think it might be helpful to take a step back and ask the "what are we trying to achieve?" question with every change: Is it shimmer for the sake of shimmer, or is there a specific goal in mind? I'm not convinced there's utility value here, and it adds (rather than reduces) visual complexity / tech debt to manage at this time: Broken BackgroundsIn the settings view, adding a background to the entire body means a lot of weirdness is happening:
Broken primary buttonsThe animation doesn't work at all on primary color-accented buttons, and just sits there:
Stylistic incompatibility with light themes means two distinct styles now need to be managed.
Don't make major project changes in small PRs:
|
3 participants
Context
Those square buttons aren't going to curve themselves -- needed some love.
Implementation
Subtle rounding of buttons and elements, lighting effects for depth.
How to Test
Start, hit the permissions section and just LOOK at those buttons in dark theme mode
Move your mouse over and feel the shimmer go through you
Get in Touch
jasonkneen / [email protected]
Important
Enhance dark theme UI with rounded corners and shimmer effects, and add a fast development script.
vscode-button,vscode-dropdown,vscode-input, and other components inindex.cssfor dark mode.index.css.HistoryPreview.tsxto adjust button and text styles.dev:fastscript inpackage.jsonfor faster extension development.This description was created by
for b9e7f3a. It will automatically update as commits are pushed.